| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220317150116.194140-1-haowenchao@huawei.com>
Date: Thu, 17 Mar 2022 11:01:16 -0400
From: Wenchao Hao <haowenchao@...wei.com>
To: Lee Duncan <lduncan@...e.com>, Chris Leech <cleech@...hat.com>,
"James E . J . Bottomley" <jejb@...ux.ibm.com>,
Mike Christie <michael.christie@...cle.com>,
"Martin K . Petersen" <martin.petersen@...cle.com>,
<open-iscsi@...glegroups.com>, <linux-scsi@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
CC: Zhiqiang Liu <liuzhiqiang26@...wei.com>, Wu Bo <wubo40@...wei.com>,
<linfeilong@...wei.com>, Wenchao Hao <haowenchao@...wei.com>
Subject: [PATCH] scsi:libiscsi: remove unnecessary memset in iscsi_conn_setup
iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is
zero filled already including the dd_data. So it is unnecessary to
call memset again.
Signed-off-by: Wenchao Hao <haowenchao@...wei.com>
Reviewed-by: Wu Bo <wubo40@...wei.com>
Reviewed-by: Lee Duncan <lduncan@...e.com>
---
drivers/scsi/libiscsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index d09926e6c8a8..cf4211c6500d 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -3045,7 +3045,6 @@ iscsi_conn_setup(struct iscsi_cls_session *cls_session, int dd_size,
if (!cls_conn)
return NULL;
conn = cls_conn->dd_data;
- memset(conn, 0, sizeof(*conn) + dd_size);
conn->dd_data = cls_conn->dd_data + sizeof(*conn);
conn->session = session;
--
2.32.0
Powered by blists - more mailing lists