linux-kernel - [irqchip: irq/irqchip-next] irqchip/irq-qcom-mpm: fix return value check in qcom_mpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <164753123809.389.16541550679620677780.tip-bot2@tip-bot2>
Date:   Thu, 17 Mar 2022 15:33:58 -0000
From:   "irqchip-bot for Yang Yingliang" <tip-bot2@...utronix.de>
To:     linux-kernel@...r.kernel.org
Cc:     Hulk Robot <hulkci@...wei.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Shawn Guo <shawn.guo@...aro.org>,
        Marc Zyngier <maz@...nel.org>, tglx@...utronix.de
Subject: [irqchip: irq/irqchip-next] irqchip/irq-qcom-mpm: fix return value
 check in qcom_mpm_init()

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     294aee8ab6cb5d44cde4defcda43324a25c64118
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/294aee8ab6cb5d44cde4defcda43324a25c64118
Author:        Yang Yingliang <yangyingliang@...wei.com>
AuthorDate:    Wed, 16 Mar 2022 10:51:00 +08:00
Committer:     Marc Zyngier <maz@...nel.org>
CommitterDate: Thu, 17 Mar 2022 15:30:35 

irqchip/irq-qcom-mpm: fix return value check in qcom_mpm_init()

If devm_platform_ioremap_resource() fails, it never returns
NULL, replace NULL check with IS_ERR().

Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
Acked-by: Shawn Guo <shawn.guo@...aro.org>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Link: https://lore.kernel.org/r/20220316025100.1758413-1-yangyingliang@huawei.com
---
 drivers/irqchip/irq-qcom-mpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c
index eea5a75..d306146 100644
--- a/drivers/irqchip/irq-qcom-mpm.c
+++ b/drivers/irqchip/irq-qcom-mpm.c
@@ -375,7 +375,7 @@ static int qcom_mpm_init(struct device_node *np, struct device_node *parent)
 	raw_spin_lock_init(&priv->lock);
 
 	priv->base = devm_platform_ioremap_resource(pdev, 0);
-	if (!priv->base)
+	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
 
 	for (i = 0; i < priv->reg_stride; i++) {