linux-kernel - Re: [PATCH] arm64: errata: avoid duplicate field initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Mar 2022 18:10:18 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Will Deacon <will@...nel.org>, Arnd Bergmann <arnd@...nel.org>
Cc:     Rich Wiley <rwiley@...dia.com>, James Morse <james.morse@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        Arnd Bergmann <arnd@...db.de>,
        Anshuman Khandual <anshuman.khandual@....com>,
        linux-kernel@...r.kernel.org,
        Suzuki K Poulose <suzuki.poulose@....com>
Subject: Re: [PATCH] arm64: errata: avoid duplicate field initializer

On Wed, 16 Mar 2022 19:37:45 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The '.type' field is initialized both in place and in the macro
> as reported by this W=1 warning:
> 
> arch/arm64/include/asm/cpufeature.h:281:9: error: initialized field overwritten [-Werror=override-init]
>   281 |         (ARM64_CPUCAP_SCOPE_LOCAL_CPU | ARM64_CPUCAP_OPTIONAL_FOR_LATE_CPU)
>       |         ^
> arch/arm64/kernel/cpu_errata.c:136:17: note: in expansion of macro 'ARM64_CPUCAP_LOCAL_CPU_ERRATUM'
>   136 |         .type = ARM64_CPUCAP_LOCAL_CPU_ERRATUM,                         \
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> arch/arm64/kernel/cpu_errata.c:145:9: note: in expansion of macro 'ERRATA_MIDR_RANGE'
>   145 |         ERRATA_MIDR_RANGE(m, var, r_min, var, r_max)
>       |         ^~~~~~~~~~~~~~~~~
> arch/arm64/kernel/cpu_errata.c:613:17: note: in expansion of macro 'ERRATA_MIDR_REV_RANGE'
>   613 |                 ERRATA_MIDR_REV_RANGE(MIDR_CORTEX_A510, 0, 0, 2),
>       |                 ^~~~~~~~~~~~~~~~~~~~~
> arch/arm64/include/asm/cpufeature.h:281:9: note: (near initialization for 'arm64_errata[18].type')
>   281 |         (ARM64_CPUCAP_SCOPE_LOCAL_CPU | ARM64_CPUCAP_OPTIONAL_FOR_LATE_CPU)
>       |         ^
> 
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: errata: avoid duplicate field initializer
      https://git.kernel.org/arm64/c/316e46f65a54

-- 
Catalin