linux-kernel - Re: [PATCH] net: bcmgenet: Use stronger register read/writes to assure ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220318122017.24341eb1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 18 Mar 2022 12:20:17 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Peter Robinson <pbrobinson@...il.com>,
        Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org,
        opendmb@...il.com, davem@...emloft.net,
        bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Use stronger register read/writes to
 assure ordering

On Fri, 18 Mar 2022 12:01:20 -0700 Florian Fainelli wrote:
> Given the time crunch we should go with Jeremy's patch that uses
> stronger I/O access method and then we will work with Jeremy offline to
> make sure that our version of GCC12 is exactly the same as his, as well
> as the compiler options (like -mtune/-march) to reproduce this.
> 
> If we believe this is only a problem with GCC12 and 5.17 in Fedora, then
> I would be inclined to remove the Fixes tag such that when we come up
> with a more localized solution we do not have to revert "net: bcmgenet:
> Use stronger register read/writes to assure ordering" from stable
> branches. This would be mostly a courtesy to our future selves, but an
> argument could be made that this probably has always existed, and that
> different compilers could behave more or less like GCC12.

Are you expecting this patch to make 5.17? If Linus cuts final this
weekend, as he most likely will, unless we do something special the
patch in question will end up getting merged during the merge window.
Without the Fixes tag you'll need to manually instruct Greg to pull 
it in. Is that the plan?