linux-kernel - Re: [PATCH v6 0/6] selftests/resctrl: Add resctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7b28139-c097-385d-be22-c61f82409626@intel.com>
Date:   Fri, 18 Mar 2022 14:00:49 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Shaopeng Tan <tan.shaopeng@...fujitsu.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Shuah Khan <shuah@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v6 0/6] selftests/resctrl: Add resctrl_tests into
 kselftest set

Hi Shaopeng Tan,

On 3/18/2022 12:58 AM, Shaopeng Tan wrote:
> Hello,
> 
> The aim of this series is to make resctrl_tests run by using
> kselftest framework.
> - I modify resctrl_test Makefile and kselftest Makefile,
>   to enable build/run resctrl_tests by using kselftest framework.
>   Of course, users can also build/run resctrl_tests without
>   using framework as before.
> - I change the default limited time for resctrl_tests to 120 seconds, to
>   ensure the resctrl_tests finish in limited time on different environments.
> - When resctrl file system is not supported by environment or
>   resctrl_tests is not run as root, return skip code of kselftest framework.
> - If resctrl_tests does not finish in limited time, terminate it as
>   same as executing ctrl+c that kills parent process and child process.
> 
> Difference from v5:
> - Changed skip message when resctrlfs is not supported. [PATCH v6 3/6]
> - Changed resctrl's Makefile to always build with latest kernel headers and
>   keep enabling gcc checks to detect buffer overflows. [PATCH v6 4/6]
> - Made README easier to understand. [PATCH v6 5/6]
> https://lore.kernel.org/lkml/20220311072147.3301525-1-tan.shaopeng@jp.fujitsu.com/ [PATCH V5]
> 
> This patch series is based on v5.17-rc8.
> 

I do not think this is accurate because the KHDR_INCLUDES you use in patch 4/6
does not yet exist in v5.17.rc8. It seems to be available on the "next" branch
of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git

Reinette