linux-kernel - Re: [PATCH v2] Add FAT messages to printk index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Mar 2022 05:20:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jonathan Lassoff <jof@...jof.com>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:     kbuild-all@...ts.01.org, Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        linux-kernel@...r.kernel.org, Jonathan Lassoff <jof@...jof.com>
Subject: Re: [PATCH v2] Add FAT messages to printk index

Hi Jonathan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on hnaz-mm/master]
[also build test WARNING on linux/master linus/master v5.17-rc8 next-20220318]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jonathan-Lassoff/Add-FAT-messages-to-printk-index/20220319-012711
base:   https://github.com/hnaz/linux-mm master
config: m68k-defconfig (https://download.01.org/0day-ci/archive/20220319/202203190531.boviZgnl-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e3f2c52ef480a29ed0b693801bcd9497c19b89ab
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jonathan-Lassoff/Add-FAT-messages-to-printk-index/20220319-012711
        git checkout e3f2c52ef480a29ed0b693801bcd9497c19b89ab
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash fs/fat/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   fs/fat/misc.c:49: warning: Function parameter or member 'sb' not described in '_fat_msg'
   fs/fat/misc.c:49: warning: Function parameter or member 'level' not described in '_fat_msg'
   fs/fat/misc.c:49: warning: Function parameter or member 'fmt' not described in '_fat_msg'
>> fs/fat/misc.c:49: warning: expecting prototype for fat_msg(). Prototype was for _fat_msg() instead


vim +49 fs/fat/misc.c

^1da177e4c3f415 Linus Torvalds   2005-04-16  43  
81ac21d34a91e85 Oleksij Rempel   2011-04-12  44  /**
81ac21d34a91e85 Oleksij Rempel   2011-04-12  45   * fat_msg() - print preformated FAT specific messages. Every thing what is
81ac21d34a91e85 Oleksij Rempel   2011-04-12  46   * not fat_fs_error() should be fat_msg().
81ac21d34a91e85 Oleksij Rempel   2011-04-12  47   */
e3f2c52ef480a29 Jonathan Lassoff 2022-03-18  48  void _fat_msg(struct super_block *sb, const char *level, const char *fmt, ...)
81ac21d34a91e85 Oleksij Rempel   2011-04-12 @49  {
81ac21d34a91e85 Oleksij Rempel   2011-04-12  50  	struct va_format vaf;
81ac21d34a91e85 Oleksij Rempel   2011-04-12  51  	va_list args;
81ac21d34a91e85 Oleksij Rempel   2011-04-12  52  
81ac21d34a91e85 Oleksij Rempel   2011-04-12  53  	va_start(args, fmt);
81ac21d34a91e85 Oleksij Rempel   2011-04-12  54  	vaf.fmt = fmt;
81ac21d34a91e85 Oleksij Rempel   2011-04-12  55  	vaf.va = &args;
e3f2c52ef480a29 Jonathan Lassoff 2022-03-18  56  	_printk(FAT_PRINTK_PREFIX "%pV\n", level, sb->s_id, &vaf);
81ac21d34a91e85 Oleksij Rempel   2011-04-12  57  	va_end(args);
81ac21d34a91e85 Oleksij Rempel   2011-04-12  58  }
81ac21d34a91e85 Oleksij Rempel   2011-04-12  59  

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org