linux-kernel - Re: [PATCH 5.4 21/43] selftests/bpf: Add test for bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0a7298ca5c64b3d0ecfcc8821c2de79186fa9f7.camel@nokia.com>
Date:   Fri, 18 Mar 2022 07:27:07 +0000
From:   "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@...ia.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "sashal@...nel.org" <sashal@...nel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "memxor@...il.com" <memxor@...il.com>,
        "ast@...nel.org" <ast@...nel.org>
Subject: Re: [PATCH 5.4 21/43] selftests/bpf: Add test for bpf_timer
 overwriting crash

On Mon, 2022-03-14 at 12:53 +0100, Greg Kroah-Hartman wrote:
> From: Kumar Kartikeya Dwivedi <memxor@...il.com>
> 
> [ Upstream commit a7e75016a0753c24d6c995bc02501ae35368e333 ]
> 
> Add a test that validates that timer value is not overwritten when doing
> a copy_map_value call in the kernel. Without the prior fix, this test
> triggers a crash.
> 
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@...il.com>
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> Link: https://lore.kernel.org/bpf/20220209070324.1093182-3-memxor@gmail.com
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Hi, this patch in 5.4.185 breaks bpf selftests build for me:

  progs/timer_crash.c:3:10: fatal error: 'vmlinux.h' file not found
  #include <vmlinux.h>
           ^~~~~~~~~~~

Based on quick look, vmlinux.h generation was added to selftests in v5.7,
so drop this patch in v5.4?

-Tommi


> ---
>  .../selftests/bpf/prog_tests/timer_crash.c    | 32 +++++++++++
>  .../testing/selftests/bpf/progs/timer_crash.c | 54 +++++++++++++++++++
>  2 files changed, 86 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/prog_tests/timer_crash.c
>  create mode 100644 tools/testing/selftests/bpf/progs/timer_crash.c
> 
> diff --git a/tools/testing/selftests/bpf/progs/timer_crash.c b/tools/testing/selftests/bpf/progs/timer_crash.c
> new file mode 100644
> index 000000000000..f8f7944e70da
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/timer_crash.c
> @@ -0,0 +1,54 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <vmlinux.h>
> +#include <bpf/bpf_tracing.h>
> +#include <bpf/bpf_helpers.h>
> +