linux-kernel - RE: [PATCH 1/2] iio:filter:admv8818: Add depends on REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR03MB678617206D33B41868D565B499139@PH0PR03MB6786.namprd03.prod.outlook.com>
Date:   Fri, 18 Mar 2022 08:45:33 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Wang ShaoBo <bobo.shaobowang@...wei.com>
CC:     "cj.chengjian@...wei.com" <cj.chengjian@...wei.com>,
        "liwei391@...wei.com" <liwei391@...wei.com>,
        "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "Jonathan.Cameron@...wei.com" <Jonathan.Cameron@...wei.com>
Subject: RE: [PATCH 1/2] iio:filter:admv8818: Add depends on REGMAP

Hi Wang,

Thanks for the patch

> -----Original Message-----
> From: Wang ShaoBo <bobo.shaobowang@...wei.com>
> Sent: Friday, March 18, 2022 3:59 AM
> Cc: cj.chengjian@...wei.com; liwei391@...wei.com;
> bobo.shaobowang@...wei.com; Miclaus, Antoniu
> <Antoniu.Miclaus@...log.com>; linux-iio@...r.kernel.org; linux-
> kernel@...r.kernel.org; jic23@...nel.org;
> Jonathan.Cameron@...wei.com
> Subject: [PATCH 1/2] iio:filter:admv8818: Add depends on REGMAP
> 
> [External]
> 
> Add "depends on REGMAP" to CONFIG_ADMV8818, because
> admv8818 driver
> uses structure/symbols such as 'struct regmap_config' which are
> defined
> only when CONFIG_REGMAP is set.
> 
> Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@...wei.com>
> ---
>  drivers/iio/filter/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig
> index 3ae35817ad82..4bbf10f8692c 100644
> --- a/drivers/iio/filter/Kconfig
> +++ b/drivers/iio/filter/Kconfig
> @@ -7,7 +7,7 @@ menu "Filters"
> 
>  config ADMV8818
>  	tristate "Analog Devices ADMV8818 High-Pass and Low-Pass
> Filter"
> -	depends on SPI && COMMON_CLK && 64BIT
> +	depends on REGMAP && SPI && COMMON_CLK && 64BIT

I think the best way is to have select REGMAP_SPI. Hence:

    depends on SPI && COMMON_CLK && 64BIT
    select REGMAP_SPI

This will automatically default CONFIG_REGMAP to y. with your
patch, I guess we can still have issues with ' __devm_regmap_init_spi()'

- Nuno Sá