linux-kernel - Re: [PATCH v4] net:bonding:Add support for IPV6 RLB to balance-alb mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eed6ba63-9e49-5351-215c-a70573e4c79a@chinatelecom.cn>
Date:   Fri, 18 Mar 2022 17:50:06 +0800
From:   孙守鑫 <sunshouxin@...natelecom.cn>
To:     David Ahern <dsahern@...nel.org>, j.vosburgh@...il.com,
        vfalico@...il.com, andy@...yhouse.net, davem@...emloft.net,
        kuba@...nel.org, yoshfuji@...ux-ipv6.org, oliver@...kum.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        huyd12@...natelecom.cn
Subject: Re: [PATCH v4] net:bonding:Add support for IPV6 RLB to balance-alb
 mode


在 2022/3/18 2:49, David Ahern 写道:
> On 3/17/22 12:15 AM, Sun Shouxin wrote:
>> This patch is implementing IPV6 RLB for balance-alb mode.
>>
>> Suggested-by: Hu Yadi <huyd12@...natelecom.cn>
>> Signed-off-by: Sun Shouxin <sunshouxin@...natelecom.cn>
>> ---
>> changelog:
>> v1-->v2:
>> -Remove ndisc_bond_send_na and refactor ndisc_send_na.
>> -In rlb_nd_xmit, if the lladdr is not local, return curr_active_slave.
>> -Don't send neighbor advertisement message when receiving
>>   neighbor advertisement message in rlb6_update_entry_from_na.
>>
>> v2-->v3:
>> -Don't export ndisc_send_na.
>> -Use ipv6_stub->ndisc_send_na to replace ndisc_send_na
>>   in rlb6_update_client.
>>
>> v3-->v4:
>> -Submit all code at a whole patch.
> you misunderstood Jakub's comment. The code should evolve with small,
> focused patches and each patch needs to compile and function correctly
> (ie., no breakage).
>
> You need to respond to Jiri's question about why this feature is needed.
> After that:
>
> 1. patch 1 adds void *data to ndisc_send_na stub function and
> ndisc_send_na direct function. Update all places that use both
> ndisc_send_na to pass NULL as the data parameter.
>
> 2. patch 2 refactors ndisc_send_na to handle the new data argument
>
> 3. patch 3 exports any IPv6 functions. explain why each needs to be
> exported.
>
> 4. patch 4 .... bonding changes. (bonding folks can respond on how to
> introduce that change).


Thanks your warmly instruction for newbee, I'll resend soon.
Thanks again.