linux-kernel - Re: [PATCH 2/2 RESEND] drm/bridge: Add extra checks in pre_enable and post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <399aa873-4285-cc48-8c58-89673c505cb0@collabora.com>
Date:   Fri, 18 Mar 2022 11:21:41 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Ricardo Cañuelo <ricardo.canuelo@...labora.com>,
        dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        kernel@...labora.com, andrzej.hajda@...el.com,
        narmstrong@...libre.com, maarten.lankhorst@...ux.intel.com,
        mripard@...nel.org
Subject: Re: [PATCH 2/2 RESEND] drm/bridge: Add extra checks in pre_enable and
 post_enable

Il 11/03/22 10:34, Ricardo Cañuelo ha scritto:
> Depending on the bridge code, certain userspace events during a driver
> teardown (such as a DRM ioctl call) might cause a race condition where
> the drm_bridge_chain_pre_enable() and drm_bridge_chain_post_enable()
> functions could be called for a bridge that has just been detached and
> removed from the bridge chain of an encoder.
> 
> This change makes these functions a bit more robust by bailing out if
> the bridge has already been detached.
> 
> Tested on an Acer Chromebook R13 (Elm, MT8173) with Debian Sid.
> 
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@...labora.com>

On various chromebooks with different MediaTek SoC models, and on
Qualcomm SC7180 Trogdor,

Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>