linux-kernel - Re: [PATCH] csky: Move to generic ticket-spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0NMPVGVw7===uEOtNnu1hr1GqimMbZT+Kea1CUxRvPmw@mail.gmail.com>
Date:   Fri, 18 Mar 2022 11:57:43 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Guo Ren <guoren@...nel.org>
Cc:     Palmer Dabbelt <palmer@...osinc.com>, linux-csky@...r.kernel.org,
        linux-arch <linux-arch@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH] csky: Move to generic ticket-spinlock

On Fri, Mar 18, 2022 at 9:34 AM <guoren@...nel.org> wrote:
> @@ -3,6 +3,8 @@ generic-y += asm-offsets.h
>  generic-y += extable.h
>  generic-y += gpio.h
>  generic-y += kvm_para.h
> +generic-y += ticket-lock.h
> +generic-y += ticket-lock-types.h
>  generic-y += qrwlock.h
>  generic-y += user.h
>  generic-y += vmlinux.lds.h

If these headers are not included from architecture-independent code,
they should
not be marked as generic-y, same as for the qrwlock.h header

> +#include <asm/ticket-lock.h>
>  #include <asm/qrwlock.h>
>
> ...
> +#include <asm/ticket-lock-types.h>
>  #include <asm-generic/qrwlock_types.h>
>

So these should all become

#include <asm-generic/...h>

It would however make sense to have the trivial two-line version
of the two header files and put them into asm-generic/spinlock.h
and asm-generic/spinlock-types.h, replacing the current version.

If you do that, then you need a 'generic-y' line for spinlock.h,
but not for the other ones.

       Arnd