linux-kernel - Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support EDAC on imx8mp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Mar 2022 12:56:01 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Sherry Sun <sherry.sun@....com>, robh+dt@...nel.org,
        krzk+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-imx@....com,
        Dinh Nguyen <dinguyen@...nel.org>
Subject: Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support
 EDAC on imx8mp

On 18/03/2022 12:35, Sherry Sun wrote:
> i.MX8MP use synopsys V3.70a ddr controller IP, so add edac support
> for i.MX8MP based on "snps,ddrc-3.80a" synopsys edac driver.
> 
> Signed-off-by: Sherry Sun <sherry.sun@....com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 794d75173cf5..a6124a11d6ee 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -902,6 +902,12 @@
>  			interrupt-parent = <&gic>;
>  		};
>  
> +		edacmc: memory-controller@...00000 {
> +			compatible = "snps,ddrc-3.80a";
> +			reg = <0x3d400000 0x400000>;
> +			interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;

This is not correct according to the bindings. Dinh's commit adding the
compatible might not be correct, so please first fix bindings.

While fixing bindings, order the compatibles by name (s goes before x).


Best regards,
Krzysztof