linux-kernel - Re: [PATCH v2 2/3] usb: xhci: Remove unwanted header inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Mar 2022 13:01:04 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sandeep Maheswaram <quic_c_sanm@...cinc.com>
Cc:     Felipe Balbi <balbi@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Doug Anderson <dianders@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Pawel Laszczak <pawell@...ence.com>,
        Peter Chen <peter.chen@...nel.org>,
        Roger Quadros <rogerq@...nel.org>,
        Aswath Govindraju <a-govindraju@...com>,
        linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_pkondeti@...cinc.com,
        quic_ppratap@...cinc.com
Subject: Re: [PATCH v2 2/3] usb: xhci: Remove unwanted header inclusion

On Tue, Mar 01, 2022 at 03:58:26PM +0530, Sandeep Maheswaram wrote:
> Remove the header file and forward declare struct usb_hcd.

Why?

> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@...cinc.com>
> ---
>  include/linux/usb/xhci-plat.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/usb/xhci-plat.h b/include/linux/usb/xhci-plat.h
> index 906e907..576e400 100644
> --- a/include/linux/usb/xhci-plat.h
> +++ b/include/linux/usb/xhci-plat.h
> @@ -9,7 +9,8 @@
>  #define _XHCI_PLAT_H
>  
>  #include <linux/types.h>
> -#include <linux/usb/hcd.h>
> +
> +struct usb_hcd;
>  
>  struct xhci_plat_priv {
>  	const char *firmware_name;
> -- 
> 2.7.4
> 

Where did this come from?  Is this fixing a build breakage from a
previous patch?  If not, why is this needed?

confused,

greg k-h