linux-kernel - Re: [PATCH] misc: rtsx: fix indenting in rts5228_extra_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YjSArZ10NZLsJ3vb@kroah.com>
Date:   Fri, 18 Mar 2022 13:53:01 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Ricky WU <ricky_wu@...ltek.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] misc: rtsx: fix indenting in rts5228_extra_init_hw()

On Mon, Mar 07, 2022 at 05:14:21PM +0300, Dan Carpenter wrote:
> This code should be indented one more tab.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> Introduced in commit 86f4c65fd500 ("misc: rtsx: rts522a rts5228 rts5261
> support Runtime PM").  No Fixes tag because it's not a bug.
> 
>  drivers/misc/cardreader/rts5228.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/cardreader/rts5228.c b/drivers/misc/cardreader/rts5228.c
> index af581f4f74d1..ec97854e1f70 100644
> --- a/drivers/misc/cardreader/rts5228.c
> +++ b/drivers/misc/cardreader/rts5228.c
> @@ -491,9 +491,9 @@ static int rts5228_extra_init_hw(struct rtsx_pcr *pcr)
>  
>  	if (pcr->rtd3_en) {
>  		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x01);
> -	rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
> -				FORCE_PM_CONTROL | FORCE_PM_VALUE,
> -				FORCE_PM_CONTROL | FORCE_PM_VALUE);
> +		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
> +					FORCE_PM_CONTROL | FORCE_PM_VALUE,
> +					FORCE_PM_CONTROL | FORCE_PM_VALUE);
>  	} else {
>  		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x00);
>  		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
> -- 
> 2.20.1
> 

Someone beat you to it:
	https://lore.kernel.org/r/20220303020206.98911-1-yang.lee@linux.alibaba.com