linux-kernel - Re: [PATCH] firmware: edd: Remove redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Mar 2022 14:15:33 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     sudeep.holla@....com, cristian.marussi@....com, ardb@...nel.org,
        bjorn.andersson@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: edd: Remove redundant condition

On Thu, Mar 17, 2022 at 06:05:20PM +0800, Haowen Bai wrote:
> The logic !A || A && B is equivalent to !A || B. so we have
> to make code clear.

But the logic here is:
	(!A || (A && B))
not:
	(!A || A && B)

as you write.

Is that the same?  I don't want to have to dig up my son's logic
textbook...

How did you test this?

thanks,

greg k-h