linux-kernel - Re: [PATCH v2] i2c: add tracepoints for I2C slave events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f376c43-3a37-4972-f614-180968ec59eb@quicinc.com>
Date:   Fri, 18 Mar 2022 07:14:47 -0700
From:   Jae Hyun Yoo <quic_jaehyoo@...cinc.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     Wolfram Sang <wsa@...nel.org>, Ingo Molnar <mingo@...hat.com>,
        Jamie Iles <quic_jiles@...cinc.com>,
        Graeme Gregory <quic_ggregory@...cinc.com>,
        <linux-kernel@...r.kernel.org>, <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: add tracepoints for I2C slave events

Hi Steven,

On 3/18/2022 7:02 AM, Steven Rostedt wrote:

[...]

>> +	TP_printk("i2c-%d a=%03x %s [%*phD]",
>> +		__entry->adapter_nr, __entry->addr,
>> +		__print_symbolic(__entry->event,
>> +				 { I2C_SLAVE_READ_REQUESTED,	"RD_REQ" },
>> +				 { I2C_SLAVE_WRITE_REQUESTED,	"WR_REQ" },
>> +				 { I2C_SLAVE_READ_PROCESSED,	"RD_PRO" },
>> +				 { I2C_SLAVE_WRITE_RECEIVED,	"WR_RCV" },
>> +				 { I2C_SLAVE_STOP,		"  STOP" }),
> 
> For the above to be useful for perf and trace-cmd (user space tools) you
> will need to export them with:
> 
> TRACE_DEFINE_ENUM(I2C_SLAVE_READ_REQUESTED);
> TRACE_DEFINE_ENUM(I2C_SLAVE_WRITE_REQUESTED);
> TRACE_DEFINE_ENUM(I2C_SLAVE_READ_PROCESSED);
> TRACE_DEFINE_ENUM(I2C_SLAVE_WRITE_PROCESSED);
> TRACE_DEFINE_ENUM(I2C_SLAVE_STOP);
> 
> before the TRACE_EVENT()

Got it. I'll add it to v3.

Thanks,
Jae