linux-kernel - Re: [PATCH] perf parse-events: Ignore case in topdown.slots check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YjSXAFDJDbrPao6d@kernel.org>
Date:   Fri, 18 Mar 2022 11:28:16 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Kan Liang <kan.liang@...ux.intel.com>,
        Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Andi Kleen <ak@...ux.intel.com>,
        James Clark <james.clark@....com>,
        John Garry <john.garry@...wei.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Stephane Eranian <eranian@...gle.com>,
        Caleb Biggers <caleb.biggers@...el.com>
Subject: Re: [PATCH] perf parse-events: Ignore case in topdown.slots check

Em Thu, Mar 17, 2022 at 03:43:09PM -0700, Ian Rogers escreveu:
> An issue with icelakex metrics:
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/pmu-events/arch/x86/icelakex/icx-metrics.json?h=perf/core&id=65eab2bc7dab326ee892ec5a4c749470b368b51a#n48
> That causes the slots not to be first.

Thanks, applied.

- Arnaldo

 
> Fixes: 94dbfd6781a0 ("perf parse-events: Architecture specific leader override")
> Reported-by: Caleb Biggers <caleb.biggers@...el.com>
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/arch/x86/util/evlist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/arch/x86/util/evlist.c b/tools/perf/arch/x86/util/evlist.c
> index f924246eff78..8d9b55959256 100644
> --- a/tools/perf/arch/x86/util/evlist.c
> +++ b/tools/perf/arch/x86/util/evlist.c
> @@ -29,7 +29,7 @@ struct evsel *arch_evlist__leader(struct list_head *list)
>  
>  	__evlist__for_each_entry(list, evsel) {
>  		if (evsel->pmu_name && !strcmp(evsel->pmu_name, "cpu") &&
> -			evsel->name && strstr(evsel->name, "slots"))
> +			evsel->name && strcasestr(evsel->name, "slots"))
>  			return evsel;
>  	}
>  	return first;
> -- 
> 2.35.1.894.gb6a874cedc-goog

-- 

- Arnaldo