linux-kernel - Re: [PATCHv6 16/30] x86/boot: Port I/O: add decompression-time support for TDX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874k3vcp1y.ffs@tglx>
Date:   Fri, 18 Mar 2022 15:28:57 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:     mingo@...hat.com, bp@...en8.de, dave.hansen@...el.com,
        luto@...nel.org, peterz@...radead.org,
        sathyanarayanan.kuppuswamy@...ux.intel.com, aarcange@...hat.com,
        ak@...ux.intel.com, dan.j.williams@...el.com, david@...hat.com,
        hpa@...or.com, jgross@...e.com, jmattson@...gle.com,
        joro@...tes.org, jpoimboe@...hat.com, knsathya@...nel.org,
        pbonzini@...hat.com, sdeep@...are.com, seanjc@...gle.com,
        tony.luck@...el.com, vkuznets@...hat.com, wanpengli@...cent.com,
        thomas.lendacky@....com, brijesh.singh@....com, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: [PATCHv6 16/30] x86/boot: Port I/O: add decompression-time
 support for TDX

On Thu, Mar 17 2022 at 23:15, Kirill A. Shutemov wrote:
> On Thu, Mar 17, 2022 at 01:15:01PM +0100, Thomas Gleixner wrote:
>> On Wed, Mar 16 2022 at 05:08, Kirill A. Shutemov wrote:
>> >  void early_tdx_detect(void)
>> >  {
>> >  	u32 eax, sig[3];
>> > @@ -23,4 +94,12 @@ void early_tdx_detect(void)
>> >  
>> >  	/* Cache TDX guest feature status */
>> >  	tdx_guest_detected = true;
>> > +
>> > +	/* Use hypercalls instead of I/O instructions */
>> > +	inb = tdx_inb;
>> 
>> Eeew. What's wrong with writing this out?
>> 
>>         pio_ops.inb = tdx_inb;
>> 
>> So it becomes obvious what this is about?
>
> This leads to preprocessor hell: "pio_ops.inb" is expanded to
> "pio_ops.pio_ops.inb" :/
>
> I can rename fields in struct port_io_ops to avoid conflicts, I donno.

Yes, please rename them.

Thanks,

        tglx