linux-kernel - [PATCH] staging: sm750fb: add necessary #include in sm750_accel.h, sm750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Mar 2022 17:50:46 +0100
From:   Nam Cao <namcaov@...il.com>
To:     sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Cc:     Nam Cao <namcaov@...il.com>
Subject: [PATCH] staging: sm750fb: add necessary #include in sm750_accel.h, sm750_cursor.h

In sm750_cursor.h, struct lynx_cursor is used without including the
header file where this struct is defined. Similar thing is seen in
sm750_accel.h.

The module can still be compiled because there is "#include "sm750.h""
before every "#include "sm750_accel.h"" and "#include "sm750_cursor.h"".
However, the order of #include should not affect the ability to compile.

Add "#include "sm750.h"" to sm750_accel.h and sm750_cursor.h.

Signed-off-by: Nam Cao <namcaov@...il.com>
---
 drivers/staging/sm750fb/sm750_accel.h  | 2 ++
 drivers/staging/sm750fb/sm750_cursor.h | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/drivers/staging/sm750fb/sm750_accel.h b/drivers/staging/sm750fb/sm750_accel.h
index 2c79cb730a0a..fe6ff196272c 100644
--- a/drivers/staging/sm750fb/sm750_accel.h
+++ b/drivers/staging/sm750fb/sm750_accel.h
@@ -2,6 +2,8 @@
 #ifndef ACCEL_H__
 #define ACCEL_H__
 
+#include "sm750.h"
+
 #define HW_ROP2_COPY 0xc
 #define HW_ROP2_XOR 0x6
 
diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h
index b59643dd61ed..f023b691ac0b 100644
--- a/drivers/staging/sm750fb/sm750_cursor.h
+++ b/drivers/staging/sm750fb/sm750_cursor.h
@@ -2,6 +2,8 @@
 #ifndef LYNX_CURSOR_H__
 #define LYNX_CURSOR_H__
 
+#include "sm750.h"
+
 /* hw_cursor_xxx works for voyager,718 and 750 */
 void sm750_hw_cursor_enable(struct lynx_cursor *cursor);
 void sm750_hw_cursor_disable(struct lynx_cursor *cursor);
-- 
2.25.1