linux-kernel - Re: (subset) [PATCH v2 3/3] elf: Don't write past end of notes for regset gap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164762391838.2488263.14084209091132578014.b4-ty@chromium.org>
Date:   Fri, 18 Mar 2022 10:18:42 -0700
From:   Kees Cook <keescook@...omium.org>
To:     viro@...iv.linux.org.uk,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        dan.j.williams@...el.com, dave.hansen@...el.com,
        ebiederm@...ssion.com, tony.luck@...el.com, len.brown@...el.com,
        rafael.j.wysocki@...el.com, reinette.chatre@...el.com
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        linux-fsdevel@...r.kernel.org
Subject: Re: (subset) [PATCH v2 3/3] elf: Don't write past end of notes for regset gap

On Thu, 17 Mar 2022 12:20:13 -0700, Rick Edgecombe wrote:
> In fill_thread_core_info() the ptrace accessible registers are collected
> to be written out as notes in a core file. The note array is allocated
> from a size calculated by iterating the user regset view, and counting the
> regsets that have a non-zero core_note_type. However, this only allows for
> there to be non-zero core_note_type at the end of the regset view. If
> there are any gaps in the middle, fill_thread_core_info() will overflow the
> note allocation, as it iterates over the size of the view and the
> allocation would be smaller than that.
> 
> [...]

Applied to for-next/execve, thanks!

[3/3] elf: Don't write past end of notes for regset gap
      https://git.kernel.org/kees/c/dd664099002d

-- 
Kees Cook