linux-kernel - Re: [PATCH v1 1/2] Add FAT messages to printk index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHsqw9vhuD1+ZWUZgzg5ngBVyusSVLHGcWJ_Vp0k7oeKfxiHwg@mail.gmail.com>
Date:   Fri, 18 Mar 2022 10:21:54 -0700
From:   Jonathan Lassoff <jof@...jof.com>
To:     OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] Add FAT messages to printk index

On Thu, 17 Mar 2022 at 22:33, OGAWA Hirofumi
<hirofumi@...l.parknet.co.jp> wrote:

> Looks good. I prefer removing duplication of message prefix though, not
> strong opinion.
>
> e.g.
>         #define FAT_MSG_PFX             "%sFAT-fs (%s): "
>         printk_index_subsys_emit(FAT_MSG_PFX, level, fmt, ##args);\
>         _printk(FAT_MSG_PFX "%pV\n", level, sb->s_id, &vaf);
>
> Anyway, if this is same style with others, it is ok.

I would agree that defining a macro for the prefix may be useful. It
could be a nice hint to future developers that these things are
somewhat connected.

I can follow-up with a PATCH v2 to include what you suggest.

-- jof