linux-kernel - Re: [PATCH] nvmet: remove redundant assignment after left shift

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Mar 2022 11:40:55 -0600
From:   Keith Busch <kbusch@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <kch@...dia.com>,
        linux-nvme@...ts.infradead.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] nvmet: remove redundant assignment after left shift

On Fri, Mar 18, 2022 at 01:30:14AM +0000, Colin Ian King wrote:
> The left shift is followed by a re-assignment back to cc_css,
> the assignment is redundant. Fix this by replacing the <<=
> operator with << instead.
> 
> Cleans up clang scan build warning:
> drivers/nvme/target/core.c:1124:10: warning: Although the value
> stored to 'cc_css' is used in the enclosing expression, the
> value is never actually read from 'cc_css' [deadcode.DeadStores]

Looks good.

Reviewed-by: Keith Busch <kbusch@...nel.org>