linux-kernel - Re: [REGRESSION] Right touchpad button disabled on Dell 7750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Mar 2022 09:10:57 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     Takashi Iwai <tiwai@...e.de>,
        José Expósito <jose.exposito89@...il.com>,
        linux-input@...r.kernel.org,
        Peter Hutterer <peter.hutterer@...-t.net>,
        Jiri Kosina <jkosina@...e.cz>, stable@...r.kernel.org,
        regressions@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION] Right touchpad button disabled on Dell 7750

On Fri, 18 Mar 2022 15:06:55 +0100,
Benjamin Tissoires wrote:
> 
> As noticed on the libinput bug, I think the patch is wrong (not by a lot).
> We should base the class on MT_CLS_WIN8, not MT_CLS_DEFAULT.
> 
> The testers might say that it's working, but this might create some
> corner cases where it's not leading to more and more headaches with
> your users.

Indeed the first patch caused the wrong button mapping.
Jose's revised patch was confirmed to work fine.


thanks,

Takashi