linux-kernel - Re: [PATCH v18 3/8] mfd: simple-mfd-i2c: Enable support for the silergy, sy7636a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUp3ze1muL2kRDWF+msuEqNFx1ueuZ0hNXm59HiU=5vaw@mail.gmail.com>
Date:   Sat, 19 Mar 2022 10:31:32 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Alistair Francis <alistair@...stair23.me>
Cc:     Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Liam Girdwood <lgirdwood@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        linux-hwmon@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, NXP Linux Team <linux-imx@....com>,
        Zhang Rui <rui.zhang@...el.com>, alistair23@...il.com,
        Amit Kucheria <amitk@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Andreas Kemnade <andreas@...nade.info>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH v18 3/8] mfd: simple-mfd-i2c: Enable support for the
 silergy, sy7636a

Hi Alistair,

On Mon, Jan 24, 2022 at 1:24 PM Alistair Francis <alistair@...stair23.me> wrote:
> Signed-off-by: Alistair Francis <alistair@...stair23.me>
> Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>

> --- a/drivers/mfd/simple-mfd-i2c.c
> +++ b/drivers/mfd/simple-mfd-i2c.c
> @@ -62,8 +62,19 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c)
>         return ret;
>  }
>
> +static const struct mfd_cell sy7636a_cells[] = {
> +       { .name = "sy7636a-regulator", },
> +       { .name = "sy7636a-temperature", },
> +};
> +
> +static const struct simple_mfd_data silergy_sy7636a = {
> +       .mfd_cell = sy7636a_cells,
> +       .mfd_cell_size = ARRAY_SIZE(sy7636a_cells),
> +};
> +
>  static const struct of_device_id simple_mfd_i2c_of_match[] = {
>         { .compatible = "kontron,sl28cpld" },
> +       { .compatible = "silergy,sy7636a", .data = &silergy_sy7636a},
>         {}
>  };

This is slowly turning into a "board file" for an ever-growing random
bunch of devices, none of which is described in the help text?

See also my reply to patch 2/8
https://lore.kernel.org/all/CAMuHMdVy4E1pX+VLLq_05FX4pM+BPZycQgn68ArGh2s8qL24=w@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds