linux-kernel - Re: [PATCH] can: mcp251xfd: return errors from mcp251xfd_register_get_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 19 Mar 2022 16:53:30 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     trix@...hat.com
Cc:     mani@...nel.org, thomas.kopp@...rochip.com, wg@...ndegger.com,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        nathan@...nel.org, ndesaulniers@...gle.com,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] can: mcp251xfd: return errors from
 mcp251xfd_register_get_dev_id

On 19.03.2022 08:31:28, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Clang static analysis reports this issue
> mcp251xfd-core.c:1813:7: warning: The left operand
>   of '&' is a garbage value
>   FIELD_GET(MCP251XFD_REG_DEVID_ID_MASK, dev_id),
>   ^                                      ~~~~~~
> 
> dev_id is set in a successful call to
> mcp251xfd_register_get_dev_id().  Though the status
> of calls made by mcp251xfd_register_get_dev_id()
> are checked and handled, their status' are not
> returned.  So return err.
> 
> Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
> Signed-off-by: Tom Rix <trix@...hat.com>

Thanks for your patch, applied to linux-can/testing.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)