linux-kernel - Re: [PATCH] crypto: qat: Fix unsigned comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 19 Mar 2022 16:10:38 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        marco.chiappero@...el.com, fiona.trahe@...el.com,
        wojciech.ziemba@...el.com, qat-linux@...el.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: qat: Fix unsigned comparison with less than zero

On Fri, Mar 18, 2022 at 10:10:59AM +0800, Haowen Bai wrote:
> drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c:67:5-8: WARNING: Unsigned expression compared with zero: ret < 0
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>  drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
> index 6d10edc..0143835 100644
> --- a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
> +++ b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
> @@ -52,7 +52,7 @@ static const char *const dev_cfg_services[] = {
>  static int get_service_enabled(struct adf_accel_dev *accel_dev)
>  {
>  	char services[ADF_CFG_MAX_VAL_LEN_IN_BYTES] = {0};
> -	u32 ret;
> +	s32 ret;
>  
>  	ret = adf_cfg_get_param_value(accel_dev, ADF_GENERAL_SEC,
>  				      ADF_SERVICES_ENABLED, services);
A fix for this is already in the cryptodev tree:
    844318dfd31f ("crypto: qat - fix a signedness bug in get_service_enabled()")

Thanks,

-- 
Giovanni