| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Mar 2022 12:30:12 +0800
From: kernel test robot <lkp@...el.com>
To: Nick Desaulniers <ndesaulniers@...gle.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Peter Zijlstra <peterz@...radead.org>
Subject: [peterz-queue:locking/core 17/19] arch/x86/kvm/x86.h:29:2: error:
too many arguments to function 'lockdep_hardirqs_on_prepare'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/core
head: 200a79c670d24d4d9a75a6a9cbfd14af2f5d0ad9
commit: 5c9f3806a4400c2957abeea9419547f856457a20 [17/19] lockdep: Fix -Wunused-parameter for _THIS_IP_
config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220319/202203191233.qMjpfK62-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=5c9f3806a4400c2957abeea9419547f856457a20
git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue locking/core
git checkout 5c9f3806a4400c2957abeea9419547f856457a20
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/kvm/cpuid.h:5,
from arch/x86/kvm/mmu.h:7,
from arch/x86/kvm/x86.c:22:
arch/x86/kvm/x86.h: In function 'kvm_guest_enter_irqoff':
>> arch/x86/kvm/x86.h:29:2: error: too many arguments to function 'lockdep_hardirqs_on_prepare'
29 | lockdep_hardirqs_on_prepare(CALLER_ADDR0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/x86/include/asm/special_insns.h:10,
from arch/x86/include/asm/processor.h:25,
from arch/x86/include/asm/cpufeature.h:5,
from arch/x86/include/asm/thread_info.h:53,
from include/linux/thread_info.h:60,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/percpu.h:6,
from include/linux/context_tracking_state.h:5,
from include/linux/hardirq.h:5,
from include/linux/kvm_host.h:7,
from arch/x86/kvm/x86.c:19:
include/linux/irqflags.h:23:15: note: declared here
23 | extern void lockdep_hardirqs_on_prepare(void);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from arch/x86/kvm/vmx/../cpuid.h:5,
from arch/x86/kvm/vmx/evmcs.c:7:
arch/x86/kvm/vmx/../x86.h: In function 'kvm_guest_enter_irqoff':
>> arch/x86/kvm/vmx/../x86.h:29:2: error: too many arguments to function 'lockdep_hardirqs_on_prepare'
29 | lockdep_hardirqs_on_prepare(CALLER_ADDR0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/x86/include/asm/special_insns.h:10,
from arch/x86/include/asm/processor.h:25,
from arch/x86/include/asm/cpufeature.h:5,
from arch/x86/include/asm/thread_info.h:53,
from include/linux/thread_info.h:60,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/smp.h:110,
from arch/x86/kvm/vmx/evmcs.c:4:
include/linux/irqflags.h:23:15: note: declared here
23 | extern void lockdep_hardirqs_on_prepare(void);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/lockdep_hardirqs_on_prepare +29 arch/x86/kvm/x86.h
65297341d8e15b Uros Bizjak 2021-08-09 12
bc908e091b3264 Sean Christopherson 2021-05-04 13 static __always_inline void kvm_guest_enter_irqoff(void)
bc908e091b3264 Sean Christopherson 2021-05-04 14 {
bc908e091b3264 Sean Christopherson 2021-05-04 15 /*
bc908e091b3264 Sean Christopherson 2021-05-04 16 * VMENTER enables interrupts (host state), but the kernel state is
bc908e091b3264 Sean Christopherson 2021-05-04 17 * interrupts disabled when this is invoked. Also tell RCU about
bc908e091b3264 Sean Christopherson 2021-05-04 18 * it. This is the same logic as for exit_to_user_mode().
bc908e091b3264 Sean Christopherson 2021-05-04 19 *
bc908e091b3264 Sean Christopherson 2021-05-04 20 * This ensures that e.g. latency analysis on the host observes
bc908e091b3264 Sean Christopherson 2021-05-04 21 * guest mode as interrupt enabled.
bc908e091b3264 Sean Christopherson 2021-05-04 22 *
bc908e091b3264 Sean Christopherson 2021-05-04 23 * guest_enter_irqoff() informs context tracking about the
bc908e091b3264 Sean Christopherson 2021-05-04 24 * transition to guest mode and if enabled adjusts RCU state
bc908e091b3264 Sean Christopherson 2021-05-04 25 * accordingly.
bc908e091b3264 Sean Christopherson 2021-05-04 26 */
bc908e091b3264 Sean Christopherson 2021-05-04 27 instrumentation_begin();
bc908e091b3264 Sean Christopherson 2021-05-04 28 trace_hardirqs_on_prepare();
bc908e091b3264 Sean Christopherson 2021-05-04 @29 lockdep_hardirqs_on_prepare(CALLER_ADDR0);
bc908e091b3264 Sean Christopherson 2021-05-04 30 instrumentation_end();
bc908e091b3264 Sean Christopherson 2021-05-04 31
bc908e091b3264 Sean Christopherson 2021-05-04 32 guest_enter_irqoff();
bc908e091b3264 Sean Christopherson 2021-05-04 33 lockdep_hardirqs_on(CALLER_ADDR0);
bc908e091b3264 Sean Christopherson 2021-05-04 34 }
bc908e091b3264 Sean Christopherson 2021-05-04 35
:::::: The code at line 29 was first introduced by commit
:::::: bc908e091b3264672889162733020048901021fb KVM: x86: Consolidate guest enter/exit logic to common helpers
:::::: TO: Sean Christopherson <seanjc@...gle.com>
:::::: CC: Thomas Gleixner <tglx@...utronix.de>
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists