linux-kernel - Re: [PATCH] memory: samsung: exynos5422-dmc: Avoid some over memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 20 Mar 2022 13:16:53 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Lukasz Luba <lukasz.luba@....com>,
        Alim Akhtar <alim.akhtar@...sung.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Avoid some over memory
 allocation

On 20/03/2022 08:10, Christophe JAILLET wrote:
> 'dmc->counter' is a 'struct devfreq_event_dev **', so there is some
> over memory allocation. 'counters_size' should be computed with
> 'sizeof(struct devfreq_event_dev *)'.
> 
> Use 'sizeof(*dmc->counter)' instead to fix it.
> 
> While at it, use devm_kcalloc() instead of devm_kzalloc()+open coded
> multiplication.
> 
> Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> devm_kmalloc_array() could also be used to save a few cycles because the
> array is fully initialized a few lines below.
> ---
>  drivers/memory/samsung/exynos5422-dmc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Thanks, looks good. I'll take it after merge window.


Best regards,
Krzysztof