linux-kernel - Re: [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cec7367-e6ec-5fe4-94ce-c908452c9385@roeck-us.net>
Date:   Sat, 19 Mar 2022 18:01:27 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eduardo Valentin <eduval@...zon.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Eduardo Valentin <evalenti@...nel.org>
Subject: Re: [PATCH 1/1] drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER

On 3/18/22 16:30, Eduardo Valentin wrote:
> Add a thermal zone interface to the devices added
> under jc42 driver. This way, thermal zones described
> in device tree can make use of the of nodes of these
> devices.
> 

Makes sense. I'll apply the patch, but it is a functional change
and a bit too risky to include in the upcoming commit window.
I'll apply it after the commit window closes.

Thanks,
Guenter

> Cc: Guenter Roeck <linux@...ck-us.net> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
> Cc: Jean Delvare <jdelvare@...e.com> (maintainer:HARDWARE MONITORING)
> Cc: linux-hwmon@...r.kernel.org (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
> Cc: linux-kernel@...r.kernel.org (open list)
> 
> Signed-off-by: Eduardo Valentin <eduval@...zon.com>
> Signed-off-by: Eduardo Valentin <evalenti@...nel.org>
> ---
>   drivers/hwmon/jc42.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
> index cb347a6bd8d9..f40df2f29d41 100644
> --- a/drivers/hwmon/jc42.c
> +++ b/drivers/hwmon/jc42.c
> @@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
>   }
>   
>   static const struct hwmon_channel_info *jc42_info[] = {
> +	HWMON_CHANNEL_INFO(chip,
> +			   HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
>   	HWMON_CHANNEL_INFO(temp,
>   			   HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
>   			   HWMON_T_CRIT | HWMON_T_MAX_HYST |