linux-kernel - Re: [PATCH] nfsd: fix using the correct variable for sizeof()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 20 Mar 2022 17:00:05 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Jakob Koschel <jakobkoschel@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        Mike Rapoport <rppt@...nel.org>,
        Brian Johannesmeyer <bjohannesmeyer@...il.com>,
        Cristiano Giuffrida <c.giuffrida@...nl>,
        "Bos, H.J." <h.j.bos@...nl>
Subject: Re: [PATCH] nfsd: fix using the correct variable for sizeof()


> On Mar 19, 2022, at 4:27 PM, Jakob Koschel <jakobkoschel@...il.com> wrote:
> 
> While the original code is valid, it is not the obvious choice for the
> sizeof() call and in preparation to limit the scope of the list iterator
> variable the sizeof should be changed to the size of the destination.
> 
> Signed-off-by: Jakob Koschel <jakobkoschel@...il.com>
> ---
> fs/nfsd/nfs4layouts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4layouts.c b/fs/nfsd/nfs4layouts.c
> index 6d1b5bb051c5..2c05692a9abf 100644
> --- a/fs/nfsd/nfs4layouts.c
> +++ b/fs/nfsd/nfs4layouts.c
> @@ -422,7 +422,7 @@ nfsd4_insert_layout(struct nfsd4_layoutget *lgp, struct nfs4_layout_stateid *ls)
> 	new = kmem_cache_alloc(nfs4_layout_cache, GFP_KERNEL);
> 	if (!new)
> 		return nfserr_jukebox;
> -	memcpy(&new->lo_seg, seg, sizeof(lp->lo_seg));
> +	memcpy(&new->lo_seg, seg, sizeof(new->lo_seg));
> 	new->lo_state = ls;
> 
> 	spin_lock(&fp->fi_lock);
> 
> base-commit: 34e047aa16c0123bbae8e2f6df33e5ecc1f56601
> -- 
> 2.25.1
> 

Thanks, Jakob. Applied to the for-next branch at

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git

--
Chuck Lever