linux-kernel - Re: [PATCH] dt-bindings: mmc: xenon: Convert to JSON schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1647742413.974061.2990520.nullmailer@robh.at.kernel.org>
Date:   Sat, 19 Mar 2022 20:13:33 -0600
From:   Rob Herring <robh@...nel.org>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
        ulf.hansson@...aro.org, huziji@...vell.com,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org
Subject: Re: [PATCH] dt-bindings: mmc: xenon: Convert to JSON schema

On Fri, 18 Mar 2022 16:35:21 +1300, Chris Packham wrote:
> Convert the marvell,xenon-sdhci binding to JSON schema. This is a fairly
> direct conversion so there are some requirements that are documented in
> prose but not currently enforced.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
>  .../bindings/mmc/marvell,xenon-sdhci.txt      | 173 ------------
>  .../bindings/mmc/marvell,xenon-sdhci.yaml     | 252 ++++++++++++++++++
>  2 files changed, 252 insertions(+), 173 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt
>  create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml:38:13: [warning] wrong indentation: expected 14 but found 12 (indentation)
./Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml:41:13: [warning] wrong indentation: expected 14 but found 12 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):
MAINTAINERS: Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt

See https://patchwork.ozlabs.org/patch/1606868

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.