linux-kernel - Re: [PATCH] ufs: remove an unneed NULL check on list iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 20 Mar 2022 12:57:34 +0800
From:   Xiaomeng Tong <xiam0nd.tong@...il.com>
To:     jakobkoschel@...il.com
Cc:     alim.akhtar@...sung.com, avri.altman@....com, beanhuo@...ron.com,
        bvanassche@....org, daejun7.park@...sung.com, jejb@...ux.ibm.com,
        keosung.park@...sung.com, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, martin.petersen@...cle.com,
        xiam0nd.tong@...il.com
Subject: Re: [PATCH] ufs: remove an unneed NULL check on list iterator

On Sun, 20 Mar 2022 01:57:39 +0100, Jakob Koschel <jakobkoschel@...il.com> wrote:
> Maybe it make more sense to move that check after the loop body instead
> of removing it completely? This code obviously does nothing in it's current
> state but it's clear what the original intention was, so restoring that would
> perhaps be better.
> 
> But probably someone with more experience about this code can make the call
> 

This seems like a better choice, if it doesn't go against the author's original
intention. I will fix it in PATCH v2, thanks.

--
Xiaomeng Tong