linux-kernel - Re: [PATCH v4 15/18] dt-bindings: clock: Add L2 clocks to qcom,krait-cc Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YjiUfln1MzDyTDHZ@Ansuel-xps.localdomain>
Date:   Mon, 21 Mar 2022 16:06:38 +0100
From:   Ansuel Smith <ansuelsmth@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH v4 15/18] dt-bindings: clock: Add L2 clocks to
 qcom,krait-cc Documentation

On Mon, Mar 21, 2022 at 04:33:02PM +0100, Krzysztof Kozlowski wrote:
> On 21/03/2022 15:48, Ansuel Smith wrote:
> > Krait-cc qcom driver provide also L2 clocks and require the acpu_l2_aux
> > and the hfpll_l2 clock to be provided. Add these missing clocks to the
> > Documentation.
> > 
> 
> Thanks. It would be also nice to see here short sentence about expected
> impact, e.g. there are no in-tree DTSes which would be affected, no out
> of tree known users etc.
> 
> Because basically with this requirement you change the ABI, so you might
> break some users.
> 
> I will leave it to platform maintainers to decide whether it is accepted
> or not.
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> 
> Best regards,
> Krzysztof

In the driver I keep support for both and also I tested the changes with
the old wrong implementation. Both works so we shouldn't have any
regression.

-- 
	Ansuel