linux-kernel - 答复: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Mar 2022 06:11:05 +0000
From:   白浩文 <baihaowen@...zu.com>
To:     Jiri Slaby <jirislaby@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "dsterba@...e.com" <dsterba@...e.com>,
        "elder@...aro.org" <elder@...aro.org>,
        "jcmvbkbc@...il.com" <jcmvbkbc@...il.com>
CC:     "johan@...nel.org" <johan@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags

Hi, sir

Ok, thank you for your reminder.
________________________________________
发件人: Jiri Slaby <jirislaby@...nel.org>
发送时间: 2022年3月21日 14:03:09
收件人: 白浩文; arnd@...db.de; gregkh@...uxfoundation.org; dsterba@...e.com; elder@...aro.org; jcmvbkbc@...il.com
抄送: johan@...nel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags

Hi,

the $SUBJ says:

"try: synclink_cs: ..."

but you actually meant "tty:".

On 21. 03. 22, 4:04, Haowen Bai wrote:
> This silences the following coccinelle warning:
> drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
>
> we will try to make code cleaner
>
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>   drivers/char/pcmcia/synclink_cs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba5..e6f2186 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
>               // BIT7:parity error
>               // BIT6:framing error
>
> -             if (status & (BIT7 + BIT6)) {
> +             if (status & (BIT7 | BIT6)) {
>                       if (status & BIT7)
>                               icount->parity++;
>                       else


--
js
suse labs