linux-kernel - Re: [PATCH] namei: make filename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Mar 2022 11:27:28 -0700
From:   Stephen Brennan <stephen.s.brennan@...cle.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        viro@...iv.linux.org.uk
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] namei: make filename_parentat static

Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> writes:
> This symbol is not used outside of namei.c, so marks it static.
>
> Fix the following w1 warning:
>
> fs/namei.c:2587:5: warning: no previous prototype for
> ‘filename_parentat’ [-Wmissing-prototypes].
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  fs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index 44c366f3152f..fe3525807361 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2584,7 +2584,7 @@ static int __filename_parentat(int dfd, struct filename *name,
>  	return retval;
>  }
>  
> -int filename_parentat(int dfd, struct filename *name, unsigned int flags,
> +static int filename_parentat(int dfd, struct filename *name, unsigned int flags,
>  		      struct path *parent, struct qstr *last, int *type)
>  {
>  	return __filename_parentat(dfd, name, flags, parent, last, type, NULL);

You must have based this on something other than the latest upstream
tree. Currently on v5.17 we have:

2559 static int filename_parentat(int dfd, struct filename *name,
2560 			     unsigned int flags, struct path *parent,
2561 			     struct qstr *last, int *type)

Regards,
Stephen

> -- 
> 2.20.1.7.g153144c