linux-kernel - Re: [PATCH] staging: greybus: codecs: fix type confusion of list iterator variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Mar 2022 00:08:43 +0530
From:   Vaibhav Agarwal <vaibhav.sr@...il.com>
To:     Jakob Koschel <jakobkoschel@...il.com>
Cc:     open list <linux-kernel@...r.kernel.org>,
        "moderated list:GREYBUS SUBSYSTEM" <greybus-dev@...ts.linaro.org>,
        linux-staging@...ts.linux.dev, Mark Greer <mgreer@...malcreek.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mike Rapoport <rppt@...nel.org>,
        Brian Johannesmeyer <bjohannesmeyer@...il.com>,
        Cristiano Giuffrida <c.giuffrida@...nl>,
        "Bos, H.J." <h.j.bos@...nl>
Subject: Re: [PATCH] staging: greybus: codecs: fix type confusion of list
 iterator variable

On Mon, Mar 21, 2022 at 6:07 PM Jakob Koschel <jakobkoschel@...il.com> wrote:
>
> If the list does not exit early then data == NULL and 'module' does not
> point to a valid list element.
> Using 'module' in such a case is not valid and was therefore removed.
>
> Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
> Signed-off-by: Jakob Koschel <jakobkoschel@...il.com>
> ---
>  drivers/staging/greybus/audio_codec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index b589cf6b1d03..e19b91e7a72e 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -599,8 +599,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
>                         break;
>         }
>         if (!data) {
> -               dev_err(dai->dev, "%s:%s DATA connection missing\n",
> -                       dai->name, module->name);
> +               dev_err(dai->dev, "%s DATA connection missing\n",
> +                       dai->name);
>                 mutex_unlock(&codec->lock);
>                 return -ENODEV;
>         }
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613

Reviewed-by: Vaibhav Agarwal <vaibhav.sr@...il.com>


> --
> 2.25.1