linux-kernel - Re: hppa vDSO and compiler (non-)support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YjjJNb0D/b+ZXBVZ@ls3530>
Date:   Mon, 21 Mar 2022 19:51:33 +0100
From:   Helge Deller <deller@....de>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     Helge Deller <deller@....de>, linux-parisc@...r.kernel.org,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        Martin Liška <mliska@...e.cz>,
        Andreas Schwab <schwab@...ux-m68k.org>
Subject: Re: hppa vDSO and compiler (non-)support

Hello Jiri,

* Jiri Slaby <jirislaby@...nel.org>:
> On 09. 03. 22, 6:48, Jiri Slaby wrote:
> > On 08. 03. 22, 15:51, Helge Deller wrote:
> > > On 3/8/22 12:06, Jiri Slaby wrote:
> > > > since the "parisc: Add vDSO support" commit, I can no longer
> > > > cross-build a hppa kernel. I see two issues:
> > > >
> > > > 1) CROSS32_COMPILE detection doesn't work here, as openSUSE
> > > > provides hppa-suse-linux-* binaries. It's easy to overcome by
> > > > "CROSS32_COMPILE=hppa-suse-linux-"
> > >
> > ...
> > > Would it make sense to add the detection for SUSE too?
>
> So, could 1) be fixed on the Kconfig side? Or should I (people running SUSE)
> use "CROSS32_COMPILE=hppa-suse-linux-"?

Could you please try if this patch fixes it for you?

diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 2a9387a93592..7583fc39ab2d 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -42,7 +42,7 @@ export LD_BFD

 # Set default 32 bits cross compilers for vdso
 CC_ARCHES_32 = hppa hppa2.0 hppa1.1
-CC_SUFFIXES  = linux linux-gnu unknown-linux-gnu
+CC_SUFFIXES  = linux linux-gnu unknown-linux-gnu suse-linux
 CROSS32_COMPILE := $(call cc-cross-prefix, \
 	$(foreach a,$(CC_ARCHES_32), \
 	$(foreach s,$(CC_SUFFIXES),$(a)-$(s)-)))
@@ -52,7 +52,7 @@ export CROSS32CC
 # Set default cross compiler for kernel build
 ifdef cross_compiling
 	ifeq ($(CROSS_COMPILE),)
-		CC_SUFFIXES = linux linux-gnu unknown-linux-gnu
+		CC_SUFFIXES = linux linux-gnu unknown-linux-gnu suse-linux
 		CROSS_COMPILE := $(call cc-cross-prefix, \
 			$(foreach a,$(CC_ARCHES), \
 			$(foreach s,$(CC_SUFFIXES),$(a)-$(s)-)))


>
> > > > 2) openSUSE doesn't provide any libc for hppa. So gcc doesn't
> > > > provide libgcc.a and the build of vDSO fails.
> > >
> > > libgcc.a comes with the compiler, I don't think you need libc for that.
> >
> > I was told glibc is needed to build libgcc.a.
>
> 2) was fixed on the compiler (SUSE) side. cross-hppa-gcc12-bootstrap was
> introduced -- note it's known to be a misnomer -- it should have been like
> s/-bootstrap/-baremetal/.

Great!

Helge