linux-kernel - Re: [net-next PATCH v4 1/7] octeon_ep: Add driver framework and device initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220321122808.427d7872@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 21 Mar 2022 12:28:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Veerasenareddy Burru <vburru@...vell.com>
Cc:     <davem@...emloft.net>, <corbet@....net>, <netdev@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Abhijit Ayarekar <aayarekar@...vell.com>,
        Satananda Burla <sburla@...vell.com>
Subject: Re: [net-next PATCH v4 1/7] octeon_ep: Add driver framework and
 device initialization

On Sun, 20 Mar 2022 22:53:31 -0700 Veerasenareddy Burru wrote:
> Add driver framework and device setup and initialization for Octeon
> PCI Endpoint NIC.
> 
> Add implementation to load module, initilaize, register network device,
> cleanup and unload module.
> 
> Signed-off-by: Veerasenareddy Burru <vburru@...vell.com>
> Signed-off-by: Abhijit Ayarekar <aayarekar@...vell.com>
> Signed-off-by: Satananda Burla <sburla@...vell.com>

Clang says:

drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c:51:19: warning: unused function 'octep_ctrl_mbox_circq_inc' [-Wunused-function]
static inline u32 octep_ctrl_mbox_circq_inc(u32 index, u32 mask)
                  ^
drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c:56:19: warning: unused function 'octep_ctrl_mbox_circq_space' [-Wunused-function]
static inline u32 octep_ctrl_mbox_circq_space(u32 pi, u32 ci, u32 mask)
                  ^
drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c:61:19: warning: unused function 'octep_ctrl_mbox_circq_depth' [-Wunused-function]
static inline u32 octep_ctrl_mbox_circq_depth(u32 pi, u32 ci, u32 mask)
                  ^

Please don't use static inlines in C files, static is enough for 
the compiler to do a reasonable job.

Please fix and repost in 2 weeks we're currently in the merge window
so networking trees are not accepting new drivers.

Thanks.