linux-kernel - Re: [PATCH 0/8] nolibc: small updates required for the self-tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220321203319.GA8066@1wt.eu>
Date:   Mon, 21 Mar 2022 21:33:19 +0100
From:   Willy Tarreau <w@....eu>
To:     "Paul E. McKenney" <paulmck@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ammar Faizi <ammarfaizi2@...weeb.org>
Subject: Re: [PATCH 0/8] nolibc: small updates required for the self-tests

On Mon, Mar 21, 2022 at 01:29:08PM -0700, Paul E. McKenney wrote:
> On Mon, Mar 21, 2022 at 06:33:06PM +0100, Willy Tarreau wrote:
> > Hello Paul,
> > 
> > while developing the nolibc self-tests, I naturally faced a few
> > limitations ranging from missing POLL* flags to missing strcmp() or
> > getenv(), as well as the ability for printf() to print "(null)" on
> > "%s" instead of crashing.
> > 
> > This series adds a makefile and a headers installation target that
> > creates a sysroot made of kernel headers and nolibc headers, which
> > significantly ease building programs.
> > 
> > I already have some test code with roughly 75 tests, but I find it
> > misplaced in the nolibc dir, I need to move it to testing/selftests/
> > before sending it to you.
> > 
> > This series is intended to be an add-on to what you already have in your
> > dev branch. I don't intend to send you much more stuff on top of this,
> > but I expect to see an update from Ammar's patch set (CCed). With all
> > this I think we'll have a good basis to easily add new tests.
> 
> I have pulled this series in for review and testing, thank you!
> 
> It won't go into -next until v5.18-rc1 comes out, in about two weeks,
> but it will at least be in -rcu.

Perfect, thank you!

> I removed an ostensibly extraneous blank line from the end of
> tools/include/nolibc/Makefile.  So please let me know if that blank line
> is actually necessary.

Oh I'm very sorry, that the type of thing I'm very careful about so it
has definitely escaped my checks.

Thanks,
Willy