linux-kernel - Re: [PATCH V2] tty: synclink_cs: Use bitwise instead of arithmetic operator for flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23d3debb-cb2c-903a-97bf-eaf3a8e5b69d@kernel.org>
Date:   Mon, 21 Mar 2022 08:28:40 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Haowen Bai <baihaowen@...zu.com>, arnd@...db.de,
        gregkh@...uxfoundation.org, dsterba@...e.com, elder@...aro.org,
        jcmvbkbc@...il.com, johan@...nel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] tty: synclink_cs: Use bitwise instead of arithmetic
 operator for flags

On 21. 03. 22, 8:12, Haowen Bai wrote:
> This silences the following coccinelle warning:
> drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
> 
> we will try to make code cleaner
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> ---
> V1 -> V2: fix title subject misspelling try -> tty.
> 
>   drivers/char/pcmcia/synclink_cs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba5..e6f2186 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
>   		// BIT7:parity error
>   		// BIT6:framing error
>   
> -		if (status & (BIT7 + BIT6)) {
> +		if (status & (BIT7 | BIT6)) {
>   			if (status & BIT7)
>   				icount->parity++;
>   			else


-- 
js