linux-kernel - Re: [PATCH 2/2] Bluetooth: btusb: Add Intel devcoredump support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Mar 2022 15:38:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     Manish Mandlik <mmandlik@...gle.com>, marcel@...tmann.org,
        luiz.dentz@...il.com
Cc:     kbuild-all@...ts.01.org,
        chromeos-bluetooth-upstreaming@...omium.org,
        linux-bluetooth@...r.kernel.org,
        Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
        Manish Mandlik <mmandlik@...gle.com>,
        Chethan Tumkur Narayan <chethan.tumkur.narayan@...el.com>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: btusb: Add Intel devcoredump support

Hi Manish,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth/master]
[also build test WARNING on bluetooth-next/master v5.17 next-20220318]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Manish-Mandlik/Bluetooth-Add-support-for-devcoredump/20220321-093553
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
config: parisc-randconfig-r023-20220320 (https://download.01.org/0day-ci/archive/20220321/202203211500.z1bvoo6A-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/677f482cb7027ab030842015cfd6c188568df39f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Manish-Mandlik/Bluetooth-Add-support-for-devcoredump/20220321-093553
        git checkout 677f482cb7027ab030842015cfd6c188568df39f
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash drivers/bluetooth/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/bluetooth/btintel.c: In function 'btintel_register_devcoredump_support':
>> drivers/bluetooth/btintel.c:1447:9: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation]
    1447 |         strncpy(driver_name, driver, DRIVER_NAME_LEN);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/strncpy +1447 drivers/bluetooth/btintel.c

  1429	
  1430	int btintel_register_devcoredump_support(struct hci_dev *hdev,
  1431						 const char *driver)
  1432	{
  1433		struct intel_debug_features features;
  1434		int err;
  1435	
  1436		err = btintel_read_debug_features(hdev, &features);
  1437		if (err) {
  1438			bt_dev_info(hdev, "Error reading debug features");
  1439			return err;
  1440		}
  1441	
  1442		if (!(features.page1[0] & 0x3f)) {
  1443			bt_dev_info(hdev, "Telemetry exception format not supported");
  1444			return -EOPNOTSUPP;
  1445		}
  1446	
> 1447		strncpy(driver_name, driver, DRIVER_NAME_LEN);
  1448		hci_devcoredump_register(hdev, btintel_dmp_hdr, NULL);
  1449	
  1450		return err;
  1451	}
  1452	EXPORT_SYMBOL_GPL(btintel_register_devcoredump_support);
  1453	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp