linux-kernel - Re: [PATCH v4 2/2] mmc: Add mmc driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef173db6-4635-8a77-c3e3-d96b0c2fa7a3@kernel.org>
Date:   Mon, 21 Mar 2022 10:01:43 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Tony Huang 黃懷厚 <tony.huang@...plus.com>,
        Tony Huang <tonyhuang.sunplus@...il.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "lhjeff911@...il.com" <lhjeff911@...il.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
Cc:     Wells Lu 呂芳騰 <wells.lu@...plus.com>,
        Lh Kuo 郭力豪 <lh.Kuo@...plus.com>
Subject: Re: [PATCH v4 2/2] mmc: Add mmc driver for Sunplus SP7021

On 21/03/2022 05:55, Tony Huang 黃懷厚 wrote:
> Dear Krzysztof:
>>
>>> +	int dma_int_threshold;
>>> +	struct sg_mapping_iter sg_miter; /* for pio mode to access sglist */
>>> +	int dma_use_int; /* should raise irq when dma done */
>>> +	struct spmmc_tuning_info emmc_tuning_info;
>>> +	struct spsdc_tuning_info sd_tuning_info;
>>> +	int restore_4bit_sdio_bus;
>>> +	const struct spmmc_compatible *dev_comp; };
>>> +
>>> +struct spsdc_host {
>>
>> Where is this used?
>>
> 
> struct spmmc_host{} for emmc.			
> struct spsdc_host{} for SD card.			
> The register base address and offset address of emmc and sd cards are different.			
> eMMC and sdcard are their respective hardware settings.


This is a weird answer. I asked where is this used (struct spsdc_host).
There is no single reference of this type. Your answer does not cover it
all. I know that eMMC and SD are different. That was not the question.
The question is: point me to the code which uses this type.


Best regards,
Krzysztof