linux-kernel - Re: [PATCH] staging: greybus: codecs: fix type confusion with dedicated list iterator variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Mar 2022 12:21:32 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jakob Koschel <jakobkoschel@...il.com>
Cc:     Vaibhav Agarwal <vaibhav.sr@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
        Mark Greer <mgreer@...malcreek.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mike Rapport <rppt@...nel.org>,
        Brian Johannesmeyer <bjohannesmeyer@...il.com>,
        Cristiano Giuffrida <c.giuffrida@...nl>,
        "Bos, H.J." <h.j.bos@...nl>
Subject: Re: [PATCH] staging: greybus: codecs: fix type confusion with
 dedicated list iterator variable

On Mon, Mar 21, 2022 at 10:06:13AM +0100, Jakob Koschel wrote:
> 
> > On 21. Mar 2022, at 09:48, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> > 
> > The subject says that it fixes a bug but it does not.
> 
> Thank you for your review!
> 
> I don't agree that this doesn't fix a bug:
> 
> > +		}
> > 	}
> > 	if (!data) {
> > -		dev_err(dai->dev, "%s:%s DATA connection missing\n",
> > -			dai->name, module->name);
> 
> Using 'module' when data == NULL is *guaranteed* to be a type confused
> bogus pointer. It fundamentally can never be correct.

Ah.  I did not read all the way to the end of the patch.

The bugfix needs to be sent as it's own patch.  Just the one liner.  It
needs a fixes tag as well.

[PATCH] staging: greybus: fix Oops in error message

The "module" pointer is invalid here.  It's the list iterator and we
exited the loop without finding a valid entry.

Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
Signed-off-by: You

 	if (!data) {
-		dev_err(dai->dev, "%s:%s DATA connection missing\n",
-			dai->name, module->name);
+		dev_err(dai->dev, "%s DATA connection missing\n",
+			dai->name);
 		mutex_unlock(&codec->lock);

We're happy to apply the other stuff as well, but we don't mix cleanups
and bug fixes like that.

regards,
dan carpenter