linux-kernel - Re: [PATCH v4 1/2] mm/memory-failure.c: avoid calling invalidate_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d5f2c97-992b-442c-9ecf-26ba363461aa@huawei.com>
Date:   Mon, 21 Mar 2022 10:18:01 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <akpm@...ux-foundation.org>, <naoya.horiguchi@....com>,
        <shy828301@...il.com>, <mike.kravetz@...cle.com>,
        <david@...hat.com>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] mm/memory-failure.c: avoid calling
 invalidate_inode_page() with unexpected pages

On 2022/3/20 0:20, Matthew Wilcox wrote:
> On Sun, Mar 20, 2022 at 01:13:33PM +0800, Miaohe Lin wrote:
>> invalidate_inode_page() can invalidate the pages in the swap cache because
>> the check of page->mapping != mapping is removed via Matthew's patch titled
>> "mm/truncate: Inline invalidate_complete_page() into its one caller". But
>> invalidate_inode_page() is not expected to deal with the pages in the swap
>> cache. Also non-lru movable page can reach here too. They're not page cache
>> pages. Skip these pages by checking PageSwapCache and PageLRU to fix this
>> unexpected issue.
> 
> I disagree with this changelog.
> 
> invalidate_inode_page() should not be called for pages which are not
> in the page cache.
>
> And then the patch shouldn't test PageLRU (which is actually wrong) or
> PageSwapCache().  It should simply be:
> > +	if (!PageHuge(page) && !PageAnon(page))

If we reach here, the page can be one of the PageHuge, __PageMovable and PageLRU.
If above code is used, __PageMovable can pass the check and enter the invalidate_inode_page
unexpectedly. So I think PageLRU check is necessary here. But it seems PageSwapCache
is only reliable when PageAnon, so might we should do:

+	if (!PageHuge(page) && PageLRU(page) && !PageAnon(page))

Am I miss something? Many thanks for comment.

> 
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
>>  mm/memory-failure.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
>> index 5444a8ef4867..ecf45961f3b6 100644
>> --- a/mm/memory-failure.c
>> +++ b/mm/memory-failure.c
>> @@ -2178,7 +2178,7 @@ static int __soft_offline_page(struct page *page)
>>  		return 0;
>>  	}
>>  
>> -	if (!PageHuge(page))
>> +	if (!PageHuge(page) && PageLRU(page) && !PageSwapCache(page))
>>  		/*
>>  		 * Try to invalidate first. This should work for
>>  		 * non dirty unmapped page cache pages.
>> -- 
>> 2.23.0
>>
>>
> 
> .
>