linux-kernel - Re: [PATCH V8 10/22] LoongArch: Add exception/interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0PXeEAvZeq0djqCFqPSkFe5z-bg81kcs69ZTcBSL=24Q@mail.gmail.com>
Date:   Mon, 21 Mar 2022 10:49:45 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH V8 10/22] LoongArch: Add exception/interrupt handling

On Mon, Mar 21, 2022 at 9:46 AM Huacai Chen <chenhuacai@...nel.org> wrote:
> On Mon, Mar 21, 2022 at 4:38 PM Arnd Bergmann <arnd@...db.de> wrote:
> > On Sat, Mar 19, 2022 at 3:38 PM Huacai Chen <chenhuacai@...nel.org> wrote:
> >
> > > +unsigned long eentry;
> > > +EXPORT_SYMBOL_GPL(eentry);
> > > +unsigned long tlbrentry;
> > > +EXPORT_SYMBOL_GPL(tlbrentry);
> >
> > Why are these exported to modules? Maybe add a comment here, or remove
> > the export if it's not actually needed.
>
> They are used by the kvm module in our internal repo.

Ok, that is fine then. For the moment, please add a comment about it here,
or remove the exports in the initial merge and add them back when you
submit the kvm code.

       Arnd