linux-kernel - Re: [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak for clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e69af8e-74c1-f35b-98dd-e2a77153ea09@gnuweeb.org>
Date:   Mon, 21 Mar 2022 18:38:18 +0700
From:   Ammar Faizi <ammarfaizi2@...weeb.org>
To:     Willy Tarreau <w@....eu>
Cc:     "Paul E. McKenney" <paulmck@...nel.org>,
        Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>,
        Nugraha <richiisei@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        llvm@...ts.linux.dev
Subject: Re: [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak
 for clang

On 3/21/22 2:16 AM, Willy Tarreau wrote:
> Hi Ammar,
> 
> I've had a look at this one.
> 
> On Sun, Mar 20, 2022 at 04:37:46PM +0700, Ammar Faizi wrote:
>> Budilig with clang yields the following error:
>    ^^^^^^^
> BTW please fix the typo in the final commit message.
> 
>> @@ -183,7 +183,9 @@ struct sys_stat_struct {
>>   
>>   /* startup code */
>>   asm(".section .text\n"
>> +#if !defined(__clang__)
>>       ".weak _start\n"
>> +#endif
>>       ".global _start\n"
>>       "_start:\n"
> 
> So it seems that I was wrong and that .weak is an alternate for .global
> and not a complement. As such, instead of adding all these #if, please
> simply remove all .global.

Will fix this in the next version.

-- 
Ammar Faizi