linux-kernel - RE: [PATCH v4 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Mar 2022 02:35:46 +0000
From:   Tony Huang 黃懷厚 <tony.huang@...plus.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Tony Huang <tonyhuang.sunplus@...il.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "lhjeff911@...il.com" <lhjeff911@...il.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
CC:     Wells Lu 呂芳騰 <wells.lu@...plus.com>
Subject: RE: [PATCH v4 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus
 SP7021

Dear Krzysztof:

> > +++ b/Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
> > @@ -0,0 +1,79 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright
> > +(C) Sunplus Ltd. Co. 2021 %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mmc/sunplus,mmc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: sunplus MMC controller
> 
> s/sunplus/Sunplus/
> 

Below is my modification:
title: Sunplus MMC Controller

> > +
> > +allOf:
> > +  - $ref: "mmc-controller.yaml"
> 
> allOf below maintainers,
> 

I will modify it.

> > +
> > +maintainers:
> > +  - Tony Huang <tonyhuang.sunplus@...il.com>
> > +  - Li-hao Kuo <lhjeff911@...il.com>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - sunplus,mmc-v1
> > +      - sunplus,mmc-v2
> 
> How did this happen? Versions of blocks are usually discouraged, unless you
> have clear specification,. The previous discussion did not end with "add v1 and
> v2".
> 
> Do you have clear documentation/specification of these blocks? If no, please
> use SoC compatibles.
> 

v1: support SDIO 2.0							
v2: support eMMC 4.41							
The register base address and offset address of emmc and sd card are different.							
eMMC and sdcard are individual hardware settings							
We need version to distinguish different speeds							

> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    minItems: 1
> 
> maxItems
> 

I will modify it.

> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +  max-frequency: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - resets
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    mmc0: mmc@...03b00 {
> > +        compatible = "sunplus,mmc-v2";
> > +        reg = <0x9c003b00 0x180>;
> > +        interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> > +        clocks = <&clkc 0x4e>;
> > +        resets = <&rstc 0x3e>;
> > +        bus-width = <8>;
> > +        max-frequency = <52000000>;
> > +        non-removable;
> > +        disable-wp;
> > +        cap-mmc-highspeed;
> > +        mmc-ddr-3_3v;
> > +        no-sdio;
> > +        no-sd;
> > +    };
> > +
> > +    mmc1: mmc@...03e80 {
> > +       compatible = "sunplus,mmc-v1";
> > +       reg = <0x9c003e80 0x280>;
> > +       interrupts = <21 IRQ_TYPE_LEVEL_HIGH>;
> > +       clocks = <&clkc 0x4f>;
> > +       resets = <&rstc 0x3f>;
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&mmc1_mux &mmc1_mux_cd>;
> > +       max-frequency = <52000000>;
> > +       disable-wp;
> > +       cap-sd-highspeed;
> > +       no-sdio;
> > +       no-mmc;
> > +    };
> > diff --git a/MAINTAINERS b/MAINTAINERS index fb18ce7..2d91431 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18242,6 +18242,12 @@ L:	netdev@...r.kernel.org
> >  S:	Maintained
> >  F:	drivers/net/ethernet/dlink/sundance.c
> >
> > +SUNPLUS MMC DRIVER
> > +M:	Tony Huang <tonyhuang.sunplus@...il.com>
> > +M: Li-hao Kuo <lhjeff911@...il.com>
> 
> Wrong indentation.

I will modify it.

> 
> > +S:	Maintained
> > +F:	Documentation/devicetree/bindings/mmc/sunplu,mmc.yaml
> 
> Wrong file name.
> 

I will modify it.