linux-kernel - Re: [PATCH -next] EDAC/altera: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Mar 2022 10:10:16 -0500
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     bp@...en8.de, mchehab@...nel.org, tony.luck@...el.com,
        james.morse@....com, rric@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] EDAC/altera: Remove unnecessary print function
 dev_err()



On 3/17/22 18:37, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
> 
> Eliminate the follow coccicheck warnings:
> ./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because
> platform_get_irq() already prints an error
> ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because
> platform_get_irq() already prints an error
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/edac/altera_edac.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index e7e8e624a436..47dc35938fa8 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -2149,10 +2149,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>   	}
>   
>   	edac->sb_irq = platform_get_irq(pdev, 0);
> -	if (edac->sb_irq < 0) {
> -		dev_err(&pdev->dev, "No SBERR IRQ resource\n");
> +	if (edac->sb_irq < 0)
>   		return edac->sb_irq;
> -	}
>   
>   	irq_set_chained_handler_and_data(edac->sb_irq,
>   					 altr_edac_a10_irq_handler,
> @@ -2184,10 +2182,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>   	}
>   #else
>   	edac->db_irq = platform_get_irq(pdev, 1);
> -	if (edac->db_irq < 0) {
> -		dev_err(&pdev->dev, "No DBERR IRQ resource\n");
> +	if (edac->db_irq < 0)
>   		return edac->db_irq;
> -	}
>   	irq_set_chained_handler_and_data(edac->db_irq,
>   					 altr_edac_a10_irq_handler, edac);
>   #endif

Acked-by: Dinh Nguyen <dinguyen@...nel.org>