linux-kernel - Re: [Patch v5 2/4] memory: tegra: Add MC error logging on tegra186 onward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Mar 2022 23:21:30 +0530
From:   Ashish Mhetre <amhetre@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        krzysztof.kozlowski@...onical.com, robh+dt@...nel.org,
        thierry.reding@...il.com, jonathanh@...dia.com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org
Cc:     vdumpa@...dia.com, Snikam@...dia.com
Subject: Re: [Patch v5 2/4] memory: tegra: Add MC error logging on tegra186
 onward



On 3/19/2022 9:49 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
> 
> 
> 19.03.2022 18:50, Dmitry Osipenko пишет:
>>> +    mc_has_channels = mc->soc->num_channels && mc->soc->get_int_channel;
>>> +    if (mc_has_channels) {
>>> +            int err;
>>> +
>>> +            err = mc->soc->get_int_channel(mc, &channel);
>>> +            if (err < 0)
>>> +                    return IRQ_NONE;
>>> +
>>> +            /* mask all interrupts to avoid flooding */
>>> +            status = mc_ch_readl(mc, channel, MC_INTSTATUS) & mc->soc->intmask;
>>> +    } else {
>>> +            status = mc_readl(mc, MC_INTSTATUS) & mc->soc->intmask;
>>> +    }
>> So if mc_has_channels=false, while it should be true, then you're going
>> to handle interrupt incorrectly?
> 
> I see now that num_channels and get_int_channel are const, so I don't
> see why mc_has_channels variable is needed. Use mc->soc->num_channels.
> 
> if (mc->soc->num_channels) {

Okay, I will remove mc_has_channels and replace it with
mc->soc->num_channels.