linux-kernel - Re: [PATCH v2 2/2] arm64: dts: uDPU: correct temperature sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Mar 2022 19:48:58 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Robert Marko <robert.marko@...tura.hr>
Cc:     andrew@...n.ch, gregory.clement@...tlin.com,
        sebastian.hesselbarth@...il.com, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, marek.behun@....cz
Subject: Re: [PATCH v2 2/2] arm64: dts: uDPU: correct temperature sensors

On Tuesday 22 March 2022 11:58:57 Robert Marko wrote:
> uDPU has a pair of NCT375 temperature sensors, which are TMP75C compatible
> as far as the driver is concerned.
> 
> The current LM75 compatible worked as all of the LM75 compatible sensors
> are backwards compatible with the original part, but it meant that lower
> resolution and incorrect sample rate was being used.
> 
> The "lm75" compatible has been deprecated anyway and is meant as fallback
> in order to keep older DTS-es working.
> 
> Signed-off-by: Robert Marko <robert.marko@...tura.hr>

Reviewed-by: Pali Rohár <pali@...nel.org>

> ---
> Changes in v2:
> * None
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> index ac64949bb53e..1f534c0c65f7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-uDPU.dts
> @@ -153,15 +153,15 @@ &i2c1 {
>  	scl-gpios = <&gpionb 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  	sda-gpios = <&gpionb 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  
> -	lm75@48 {
> +	nct375@48 {
>  		status = "okay";
> -		compatible = "lm75";
> +		compatible = "ti,tmp75c";
>  		reg = <0x48>;
>  	};
>  
> -	lm75@49 {
> +	nct375@49 {
>  		status = "okay";
> -		compatible = "lm75";
> +		compatible = "ti,tmp75c";
>  		reg = <0x49>;
>  	};
>  };
> -- 
> 2.35.1
>